1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/js_console.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Aug 6 18:11:10 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/049c18c41a02cf6a6934ecd5
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Fix potential null object pointer passed to JS_GetProperty in js_gotoxy()

    I'm not sure under what script conditions this could happen, but apparently Nelgin was able to produce this null pointer deref (and segfault) using DDMsgReader. This should fix issue #769

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Aug 6 18:27:43 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/a2d6dc86b0b09664a1782cb6
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Better invalid argument reporting (null object) from js_gotoxy()

    The calling script will still terminate if it does this, but at least the caller will get a useful JS exception.

    Related to fix for issue #769

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 6 17:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/097e0162ab78524539fea92c
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Parse console.inkey() timeout parameter as an *unsigned* integer

    A negative timeout value doesn't make sense and this will extend the legal (positive) range of this parameter value.

    Hopefully this will help eliminate these errors I get often:
    dd_lightbar_menu.js line 4041: Error: can't convert inputTimeoutMS to an
    integer

    But if there's some way that this parameter value is even out of the range of an unsigned 32-bit value (4294967295) then this error could still happen. Unfortunately, the JS exception doesn't report the value that failed to convert.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net